From e519563023b1109eacf345143bc9daad9f3f649c Mon Sep 17 00:00:00 2001
From: Ghost_Element <danieldw@edu.aau.at>
Date: Wed, 10 Jan 2024 21:36:30 +0100
Subject: [PATCH] .equals replaced with ==

---
 .idea/workspace.xml                        | 80 ++++++++++--------
 src/main/java/ab1/impl/GRUPPE/NFAImpl.java |  6 +-
 src/test/java/ab1/tests/myTests.java       | 94 ++++++++++++++++++++--
 3 files changed, 134 insertions(+), 46 deletions(-)

diff --git a/.idea/workspace.xml b/.idea/workspace.xml
index 610a639..7c31b47 100644
--- a/.idea/workspace.xml
+++ b/.idea/workspace.xml
@@ -4,10 +4,10 @@
     <option name="autoReloadType" value="SELECTIVE" />
   </component>
   <component name="ChangeListManager">
-    <list default="true" id="f5e08808-a5af-4c89-a1ee-21b3bcb9ae3e" name="Changes" comment="guess what works now, fker:)">
+    <list default="true" id="f5e08808-a5af-4c89-a1ee-21b3bcb9ae3e" name="Changes" comment="just some fancy shit added">
       <change beforePath="$PROJECT_DIR$/.idea/workspace.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/workspace.xml" afterDir="false" />
-      <change beforePath="$PROJECT_DIR$/src/main/java/ab1/impl/GRUPPE/NFAFactoryImpl.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/java/ab1/impl/GRUPPE/NFAFactoryImpl.java" afterDir="false" />
       <change beforePath="$PROJECT_DIR$/src/main/java/ab1/impl/GRUPPE/NFAImpl.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/main/java/ab1/impl/GRUPPE/NFAImpl.java" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/test/java/ab1/tests/myTests.java" beforeDir="false" afterPath="$PROJECT_DIR$/src/test/java/ab1/tests/myTests.java" afterDir="false" />
     </list>
     <list id="39d4ccb3-eae9-4ed4-996a-5a13f44678fa" name="Changes by carol" comment="" />
     <option name="SHOW_DIALOG" value="false" />
@@ -64,7 +64,10 @@
     "JUnit.ComplexTests.finite2Test.executor": "Debug",
     "JUnit.ComplexTests.intersection1Test.executor": "Run",
     "JUnit.ComplexTests.intersection2Test.executor": "Run",
+    "JUnit.myTests.executor": "Run",
     "JUnit.myTests.intersection1Test.executor": "Run",
+    "JUnit.myTests.myTest_1.executor": "Run",
+    "JUnit.myTests.myTest_2.executor": "Run",
     "RunOnceActivity.OpenProjectViewOnStart": "true",
     "RunOnceActivity.ShowReadmeOnStart": "true",
     "WebServerToolWindowFactoryState": "false",
@@ -83,7 +86,7 @@
     "vue.rearranger.settings.migration": "true"
   }
 }]]></component>
-  <component name="RunManager" selected="JUnit.ComplexTests">
+  <component name="RunManager" selected="JUnit.myTests">
     <configuration name="ComplexTests" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
       <module name="ETI_Abgabe" />
       <extension name="coverage">
@@ -99,22 +102,6 @@
         <option name="Make" enabled="true" />
       </method>
     </configuration>
-    <configuration name="ComplexTests.finite1Test" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
-      <module name="ETI_Abgabe" />
-      <extension name="coverage">
-        <pattern>
-          <option name="PATTERN" value="ab1.tests.*" />
-          <option name="ENABLED" value="true" />
-        </pattern>
-      </extension>
-      <option name="PACKAGE_NAME" value="ab1.tests" />
-      <option name="MAIN_CLASS_NAME" value="ab1.tests.ComplexTests" />
-      <option name="METHOD_NAME" value="finite1Test" />
-      <option name="TEST_OBJECT" value="method" />
-      <method v="2">
-        <option name="Make" enabled="true" />
-      </method>
-    </configuration>
     <configuration name="ComplexTests.finite2Test" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
       <module name="ETI_Abgabe" />
       <extension name="coverage">
@@ -131,7 +118,7 @@
         <option name="Make" enabled="true" />
       </method>
     </configuration>
-    <configuration name="ComplexTests.intersection1Test" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
+    <configuration name="myTests" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
       <module name="ETI_Abgabe" />
       <extension name="coverage">
         <pattern>
@@ -140,14 +127,29 @@
         </pattern>
       </extension>
       <option name="PACKAGE_NAME" value="ab1.tests" />
-      <option name="MAIN_CLASS_NAME" value="ab1.tests.ComplexTests" />
-      <option name="METHOD_NAME" value="intersection1Test" />
+      <option name="MAIN_CLASS_NAME" value="ab1.tests.myTests" />
+      <option name="TEST_OBJECT" value="class" />
+      <method v="2">
+        <option name="Make" enabled="true" />
+      </method>
+    </configuration>
+    <configuration name="myTests.myTest_1" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
+      <module name="ETI_Abgabe" />
+      <extension name="coverage">
+        <pattern>
+          <option name="PATTERN" value="ab1.tests.*" />
+          <option name="ENABLED" value="true" />
+        </pattern>
+      </extension>
+      <option name="PACKAGE_NAME" value="ab1.tests" />
+      <option name="MAIN_CLASS_NAME" value="ab1.tests.myTests" />
+      <option name="METHOD_NAME" value="myTest_1" />
       <option name="TEST_OBJECT" value="method" />
       <method v="2">
         <option name="Make" enabled="true" />
       </method>
     </configuration>
-    <configuration name="ComplexTests.intersection2Test" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
+    <configuration name="myTests.myTest_2" type="JUnit" factoryName="JUnit" temporary="true" nameIsGenerated="true">
       <module name="ETI_Abgabe" />
       <extension name="coverage">
         <pattern>
@@ -156,8 +158,8 @@
         </pattern>
       </extension>
       <option name="PACKAGE_NAME" value="ab1.tests" />
-      <option name="MAIN_CLASS_NAME" value="ab1.tests.ComplexTests" />
-      <option name="METHOD_NAME" value="intersection2Test" />
+      <option name="MAIN_CLASS_NAME" value="ab1.tests.myTests" />
+      <option name="METHOD_NAME" value="myTest_2" />
       <option name="TEST_OBJECT" value="method" />
       <method v="2">
         <option name="Make" enabled="true" />
@@ -176,11 +178,11 @@
     </configuration>
     <recent_temporary>
       <list>
+        <item itemvalue="JUnit.myTests" />
+        <item itemvalue="JUnit.myTests.myTest_2" />
         <item itemvalue="JUnit.ComplexTests" />
+        <item itemvalue="JUnit.myTests.myTest_1" />
         <item itemvalue="JUnit.ComplexTests.finite2Test" />
-        <item itemvalue="JUnit.ComplexTests.finite1Test" />
-        <item itemvalue="JUnit.ComplexTests.intersection2Test" />
-        <item itemvalue="JUnit.ComplexTests.intersection1Test" />
       </list>
     </recent_temporary>
   </component>
@@ -284,7 +286,15 @@
       <option name="project" value="LOCAL" />
       <updated>1704896842030</updated>
     </task>
-    <option name="localTasksCounter" value="11" />
+    <task id="LOCAL-00011" summary="just some fancy shit added">
+      <option name="closed" value="true" />
+      <created>1704898189901</created>
+      <option name="number" value="00011" />
+      <option name="presentableId" value="LOCAL-00011" />
+      <option name="project" value="LOCAL" />
+      <updated>1704898189902</updated>
+    </task>
+    <option name="localTasksCounter" value="12" />
     <servers />
   </component>
   <component name="TypeScriptGeneratedFilesManager">
@@ -310,7 +320,8 @@
     <MESSAGE value="changed nfaAddTrap, bei dem Fall, dass Transition.readSymbol() einen nullwert zurückgibt. (Thx ChatGBT)&#10;-&gt; intersectionTests funktionieren" />
     <MESSAGE value="isFinite methode recursiv..." />
     <MESSAGE value="guess what works now, fker:)" />
-    <option name="LAST_COMMIT_MESSAGE" value="guess what works now, fker:)" />
+    <MESSAGE value="just some fancy shit added" />
+    <option name="LAST_COMMIT_MESSAGE" value="just some fancy shit added" />
   </component>
   <component name="XDebuggerManager">
     <breakpoint-manager>
@@ -325,11 +336,10 @@
           <line>355</line>
           <option name="timeStamp" value="53" />
         </line-breakpoint>
-        <line-breakpoint enabled="true" type="java-line">
-          <url>file://$PROJECT_DIR$/src/test/java/ab1/tests/ComplexTests.java</url>
-          <line>141</line>
-          <option name="timeStamp" value="59" />
-        </line-breakpoint>
+        <breakpoint enabled="true" type="java-exception">
+          <properties class="ab1.FinalizedStateException" package="ab1" />
+          <option name="timeStamp" value="62" />
+        </breakpoint>
       </breakpoints>
     </breakpoint-manager>
     <watches-manager>
diff --git a/src/main/java/ab1/impl/GRUPPE/NFAImpl.java b/src/main/java/ab1/impl/GRUPPE/NFAImpl.java
index 15c1b90..f9c6732 100644
--- a/src/main/java/ab1/impl/GRUPPE/NFAImpl.java
+++ b/src/main/java/ab1/impl/GRUPPE/NFAImpl.java
@@ -423,7 +423,7 @@ public class NFAImpl implements NFA {
         Character readSymbol = path.get(path.size()-1).getElement_1();
         Transition currentTransition = new Transition(fromState, readSymbol, path.get(path.size()-1).getElement_2());
         for(int i=transitions.indexOf(currentTransition)+1;i<transitions.size();i++){
-            if(transitions.get(i).fromState().equals(fromState) && transitions.get(i).readSymbol().equals(readSymbol)){
+            if(transitions.get(i).fromState().equals(fromState) && transitions.get(i).readSymbol()==(readSymbol)){
                 String newState = transitions.get(i).toState();
                 if (stateInPath(path, newState)) {
                     //loop!
@@ -488,7 +488,7 @@ public class NFAImpl implements NFA {
     private String checkForNewLetter(List<Tuple> path, List<Transition> transitions, Character letter){
         String fromState = path.get(path.size()-2).getElement_2();
         for(Transition transition : transitions){
-            if (transition.fromState().equals(fromState) && transition.readSymbol().equals(letter)) {
+            if (transition.fromState().equals(fromState) && transition.readSymbol()==(letter)) {
                 //found new Transition
                 path.remove(path.size()-1);
                 return transition.toState();
@@ -507,7 +507,7 @@ public class NFAImpl implements NFA {
         String fromState = path.get(path.size()-1).getElement_2();
         for(Character letter : letters) {
             for (Transition transition : transitions) {
-                if(transition.fromState().equals(fromState)&&transition.readSymbol().equals(letter)){
+                if(transition.fromState().equals(fromState)&&transition.readSymbol()==(letter)){
                     //found new Transition
                     if(stateInPath(path, transition.toState())) {
                         //loop!
diff --git a/src/test/java/ab1/tests/myTests.java b/src/test/java/ab1/tests/myTests.java
index 3187091..1b33ccd 100644
--- a/src/test/java/ab1/tests/myTests.java
+++ b/src/test/java/ab1/tests/myTests.java
@@ -5,6 +5,9 @@ import ab1.NFAFactory;
 import ab1.NFAProvider;
 import ab1.Transition;
 import org.junit.jupiter.api.Test;
+
+import java.util.Random;
+
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -12,19 +15,94 @@ public class myTests {
     private final NFAFactory factory = NFAProvider.provideFactory();
 
     @Test
-    public void intersection1Test() {
-        var nfaA = buildCharLanguage('a');
-        var nfaB = buildCharLanguage('b');
+    public void myTest_1() {
+        NFA nfa_nothing_1 = factory.buildNFA("START");
+        nfa_nothing_1.addAcceptingState("START");
+        nfa_nothing_1.finalizeAutomaton();
+        assertTrue(nfa_nothing_1.acceptsWord(""));
+        assertTrue(nfa_nothing_1.isFinite());
+        NFA nfa_everything = nfa_nothing_1.complement();
+        assertFalse(nfa_everything.acceptsWord(""));
+
+        NFA nfa_nothing_2 = factory.buildNFA("START");
+        nfa_nothing_2.addAcceptingState("START");
+        nfa_nothing_2.finalizeAutomaton();
+        NFA nfa_union_1 = nfa_nothing_1.union(nfa_nothing_2);
+        assertTrue(nfa_union_1.acceptsWord(""));
+        assertFalse(nfa_union_1.acceptsWord("a"));
+        assertFalse(nfa_union_1.acceptsWord("aa"));
+        assertFalse(nfa_union_1.acceptsWord("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"));
+        assertFalse(nfa_union_1.acceptsWord("sdafhuwifhcauwnfxuawnehuinfhu"));
+        assertFalse(nfa_union_1.acceptsWord(" "));
+
+        NFA nfa_complete_everything = nfa_nothing_1.union(nfa_everything);
+        assertTrue(nfa_complete_everything.acceptsWord(""));
+        assertTrue(nfa_complete_everything.acceptsWord("a"));
+        assertTrue(nfa_complete_everything.acceptsWord("dsahfuanewqnx"));
+
+
 
-        var testInstance = nfaA.intersection(nfaB);
 
-        assertFalse(testInstance.acceptsWord("a"));
-        assertFalse(testInstance.acceptsWord("b"));
-        assertFalse(testInstance.acceptsWord("ab"));
-        assertFalse(testInstance.acceptsWord("ba"));
     }
 
+    @Test
+    public void myTest_2(){
+        NFA nfa_abcd  = factory.buildNFA("START");
+            nfa_abcd.addTransition(new Transition("START", 'a', "1"));
+            nfa_abcd.addTransition(new Transition("START", 'b', "2"));
+            nfa_abcd.addTransition(new Transition("START", 'c', "3"));
+            nfa_abcd.addTransition(new Transition("START", 'd', "4"));
+        nfa_abcd.addTransition(new Transition("1", null, "END"));
+        nfa_abcd.addTransition(new Transition("2", null, "END"));
+        nfa_abcd.addTransition(new Transition("3", null, "END"));
+        nfa_abcd.addTransition(new Transition("4", null, "END"));
+        nfa_abcd.addAcceptingState("END");
+            assertTrue(nfa_abcd.isFinite());
+            nfa_abcd.addTransition(new Transition("3", 'c', "3"));
+            assertFalse(nfa_abcd.isFinite());
+            nfa_abcd.addTransition(new Transition("3", null, "START"));
 
+            NFA nfa_cfg = factory.buildNFA("START");
+            nfa_cfg.addTransition(new Transition("START", 'c', "1"));
+        nfa_cfg.addTransition(new Transition("START", 'f', "2"));
+        nfa_cfg.addTransition(new Transition("START", 'g', "3"));
+        nfa_cfg.addAcceptingState("1");
+        nfa_cfg.addAcceptingState("2");
+        nfa_cfg.addAcceptingState("3");
+        nfa_cfg.addTransition(new Transition("1", null, "START"));
+
+            nfa_abcd.finalizeAutomaton();
+            nfa_cfg.finalizeAutomaton();
+            assertTrue(nfa_cfg.acceptsWord("c"));
+        assertTrue(nfa_cfg.acceptsWord("ccccccccccccccc"));
+            assertTrue(nfa_abcd.acceptsWord("ccccccccccccccccca"));
+            assertTrue(nfa_abcd.acceptsWord("a"));
+            assertFalse(nfa_cfg.acceptsWord("aa"));
+            NFA nfa_interception_1 = nfa_abcd.intersection(nfa_cfg);
+            assertFalse(nfa_interception_1.acceptsWord("cccccccca"));
+        assertFalse(nfa_interception_1.acceptsWord("cccccccca"));
+        assertFalse(nfa_interception_1.acceptsWord("cf"));
+        assertFalse(nfa_interception_1.acceptsWord("d"));
+        assertTrue(nfa_interception_1.acceptsWord("c"));
+        assertTrue(nfa_interception_1.acceptsWord("cccccc"));
+        assertFalse(nfa_interception_1.isFinite());
+    }
+
+    @Test
+    public void myTest_3(){
+        Random random = new Random();
+        NFA nfa = factory.buildNFA("0");
+
+        int i=0;
+        for(i=0;i<10;i++){
+            nfa.addTransition(new Transition(""+i, 'a', ""+(i+1)));
+            nfa.addTransition(new Transition(""+i, 'a', ""+(i+1)));
+        }
+        nfa.addAcceptingState(""+(i+1));
+        assertTrue(nfa.isFinite());
+
+        int random_int = random.nextInt(26);
+    }